rename labels in heapam.c?

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: rename labels in heapam.c?
Date: 2019-03-22 20:58:42
Message-ID: 20190322205842.k552i2fk5wrmcycv@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

For the umpteenth time I was annoyed by the names of labels in
heapam.c. It's really not useful to see a 'goto l1;' etc.

How about renaming l1 to retry_delete_locked, l2 to retry_update_locked,
l3 to retry_lock_tuple_locked etc? Especially with the subsidiary
functions for updates and locking, it's not always clear from context
where the goto jumps to.

Greetings,

Andres Freund

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-03-22 21:07:02 Re: speeding up planning with partitions
Previous Message Robbie Harwood 2019-03-22 20:26:32 Re: [PATCH v20] GSSAPI encryption support