Re: Row pattern recognition

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: assam258(at)gmail(dot)com
Cc: jian(dot)universality(at)gmail(dot)com, zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Row pattern recognition
Date: 2026-11-17 09:19:59
Message-ID: 20261117.181959.2095644820042588039.ishii@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Henson,

Thank you for the patches.

> Attached are six incremental patches on top of v54, as nocfbot so
> that cfbot keeps testing v54 itself. v54 still applies to master as
> it is.
>
> 0001 fixes the cfbot failure of v54. Since "Add memory/disk usage
> for Function Scan nodes in EXPLAIN" was committed on 11-10, EXPLAIN
> ANALYZE prints a Storage line under Function Scan, and rpr_explain
> fails on every platform. This updates rpr_explain.out and changes
> nothing else.
>
> 0002-0006 take out of the series what is not specific to RPR:
>
> 0002 Remove the column alias list fix for table functions
> 0003 Remove the fix for columns of relations not printed in FROM
> 0004 Test the system column name a DEFINE clause reads on a view
> column
> 0005 Remove the fix for columns that function result types gained
> 0006 Remove EXCLUDE TIES window tests
>
> The three deparse fixes that 0002, 0003 and 0005 remove are bugs in
> master as well, so I will submit them upstream on their own. If
> they cause conflicts or need further changes in the series once
> they are committed, I will send a follow-up patch then.
>
> 0004 rewrites the one rpr_base test that depended on the fix 0005
> removes. 0006 drops two window.sql tests that have nothing to do
> with RPR.
>
> Since 0001 needs a new version anyway, this seems a good moment to
> fold all six into v55. make check passes with all six applied.
>
> Meanwhile, I am studying the planner side of the patch and auditing
> v54 for defects. I will group what I find by severity and send it
> in follow-up mails.

OK, attached are the v55 patches based on the v54 plus your 6 patches.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Attachment Content-Type Size
v55-0001-Row-pattern-recognition-patch-for-raw-parser-v55.patch application/octet-stream 44.3 KB
v55-0002-Row-pattern-recognition-patch-parse-analysis.patch application/octet-stream 68.3 KB
v55-0003-Row-pattern-recognition-patch-rewriter.patch application/octet-stream 35.9 KB
v55-0004-Row-pattern-recognition-patch-planner.patch application/octet-stream 110.9 KB
v55-0005-Row-pattern-recognition-patch-executor-and-comma.patch application/octet-stream 188.0 KB
v55-0006-Row-pattern-recognition-patch-docs.patch application/octet-stream 173.9 KB
v55-0007-Row-pattern-recognition-patch-tests-SQL-data.patch application/octet-stream 784.5 KB
v55-0008-Row-pattern-recognition-patch-tests-expected.patch application/octet-stream 1.2 MB
v55-0009-Row-pattern-recognition-patch-typedefs.list.patch application/octet-stream 1.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou 2026-11-17 09:27:24 Re: Assertion failure in update_local_synced_slot(), slotsync.c:364
Previous Message Koshino Taiki 2026-11-17 08:58:51 Re: Proposal: Include CHECK constraint expression in violation error DETAIL