Re: Row pattern recognition

Hi Tatsuo,

> Attached is v54 RPR patches.

Attached are six incremental patches on top of v54, as nocfbot so
that cfbot keeps testing v54 itself. v54 still applies to master as
it is.

0001 fixes the cfbot failure of v54. Since "Add memory/disk usage
for Function Scan nodes in EXPLAIN" was committed on 11-10, EXPLAIN
ANALYZE prints a Storage line under Function Scan, and rpr_explain
fails on every platform. This updates rpr_explain.out and changes
nothing else.

0002-0006 take out of the series what is not specific to RPR:

0002 Remove the column alias list fix for table functions
0003 Remove the fix for columns of relations not printed in FROM
0004 Test the system column name a DEFINE clause reads on a view
column
0005 Remove the fix for columns that function result types gained
0006 Remove EXCLUDE TIES window tests

The three deparse fixes that 0002, 0003 and 0005 remove are bugs in
master as well, so I will submit them upstream on their own. If
they cause conflicts or need further changes in the series once
they are committed, I will send a follow-up patch then.

0004 rewrites the one rpr_base test that depended on the fix 0005
removes. 0006 drops two window.sql tests that have nothing to do
with RPR.

Since 0001 needs a new version anyway, this seems a good moment to
fold all six into v55. make check passes with all six applied.

Meanwhile, I am studying the planner side of the patch and auditing
v54 for defects. I will group what I find by severity and send it
in follow-up mails.

Best regards,
Henson