Re: Row pattern recognition

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: assam258(at)gmail(dot)com
Cc: jian(dot)universality(at)gmail(dot)com, zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Row pattern recognition
Date: 2026-06-02 10:19:12
Message-ID: 20260602.191912.1197273977474107705.ishii@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Henson,

In execRPR.c:

static void
nfa_reevaluate_dependent_vars(WindowAggState *winstate, RPRNFAContext *ctx,
int64 currentPos)

This function does not have a forward declaration. Moreover, it is put
in the "API exposed to nodeWindowAgg.c" section. If there's no
particular reason for this, I suggest to add a forward declaration for
it and move it before "API exposed to nodeWindowAgg.c" section.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2026-06-02 10:25:35 Re: Make printtup a bit faster
Previous Message Jakub Wartak 2026-06-02 10:13:09 Re: Heads Up: cirrus-ci is shutting down June 1st