Re: Row pattern recognition

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: assam258(at)gmail(dot)com
Cc: jian(dot)universality(at)gmail(dot)com, zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Row pattern recognition
Date: 2026-06-02 05:23:56
Message-ID: 20260602.142356.343550180613194547.ishii@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Oops.

> While looking into 0002, I noticed some minor ereport calling style
> issues.
>
> Recently we start to use the style:
>
> ereport(ERROR,
> errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>
> Rather than (old style):
>
> ereport(ERROR,
> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>
> Grepping patches shows following results that hire the old style.
>
> $ grep -n '(errcode' *|grep '+'
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1243:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1248:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1421:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1428:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1451:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1457:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1463:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1471:+ (errcode(ERRCODE_SYNTAX_ERROR),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1494:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> nocfbot-0002-Unify-RPR-DEFINE-walkers-and-reject-volatile-call.txt:1504:+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),

These have been fixed in 0007. Sorry for noise.

Maybe this is the only one worth to look into?

> nocfbot-0025-Reject-single-row-window-frame-in-row-pattern-rec.txt:55:+ (errcode(ERRCODE_WINDOWING_ERROR),

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-06-02 05:27:32 Re: injection_points: Switch wait/wakeup to use atomics rather than latches
Previous Message Dilip Kumar 2026-06-02 05:21:03 Re: Proposal: Conflict log history table for Logical Replication