Re: Allow to collect statistics on virtual generated columns

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Allow to collect statistics on virtual generated columns
Date: 2026-03-26 17:18:07
Message-ID: 20260327021807.3ae563de0a288086b98755fb@sraoss.co.jp
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 26 Mar 2026 16:00:38 +0000
Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:

> On Thu, 26 Mar 2026 at 15:09, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> >
> > I've attached an updated patch including the documentation and tests.
>
> I think this is a much better approach.
>
> One thing that stands out in CreateStatistics() is that the check for
> a less-than operator can be skipped if there is just a single virtual
> generated column, for the same reason as for statistics on a single
> expression. I.e., it should be possible to build statistics on a
> single virtual generated column of any data type.

I've attached a revised patch to skip the less-than operator check
for a single virtual generated column.

In fact, this change skips the check for any single column,
not just virtual generated columns. However, using a non-virtual
single column will result in an error elsewhere.

Regards,
Yugo Nagata

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
v8-0001-Allow-creating-extended-statistics-on-virtual-gen.patch text/x-diff 19.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Jones 2026-03-26 17:18:30 Re: Add XMLNamespaces to XMLElement
Previous Message Tom Lane 2026-03-26 17:16:59 Re: SQL-level pg_datum_image_equal