| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: gen_guc_tables.pl: Validate required GUC fields before code generation |
| Date: | 2025-11-11 12:28:18 |
| Message-ID: | 202511101226.g6ztjd3kpai4@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Nov-10, Chao Li wrote:
> While working on the other patch and editing guc_parameters.dat, I
> mistakenly deleted a “max” value line, then I got the following error
> during build:
> The error message is unclear and is not helpful to identify the real issue.
Funny -- I made a very similar mistake recently and was also going to
complain about the resulting error message, so +1 for getting it
improved along the lines you proposed, plus Ilmari's suggestions.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Those who use electric razors are infidels destined to burn in hell while
we drink from rivers of beer, download free vids and mingle with naked
well shaved babes." (http://slashdot.org/comments.pl?sid=44793&cid=4647152)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-11-11 12:40:39 | Re: Improve logical replication usability when tables lack primary keys |
| Previous Message | Álvaro Herrera | 2025-11-11 12:25:36 | Re: Spacing of options in getopt_long processing |