On 2025-Jun-21, Tom Lane wrote:
> Here's a shot at improving matters. I also made an effort
> at cleaning up memory leaks in libpq_pipeline.c, although
> that's surely neatnik-ism not anything meaningful.
Yeah, the code looks much better this way. I thought it was a bit odd
that a function called confirm_result_status() would actually consume
said status. Would it be better as
consume_result_status(PGconn *conn, ExecStatusType expected)
?
I think the patch is a clear improvement regardless.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"World domination is proceeding according to plan" (Andrew Morton)