Re: Fix a typo of comments in AutoVacLauncherMain

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix a typo of comments in AutoVacLauncherMain
Date: 2025-08-04 01:03:38
Message-ID: 20250804100338.73bdabcd3935f8c9f7b4db55@sraoss.co.jp
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 1 Aug 2025 10:00:48 -0700
Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:

> On Fri, Aug 1, 2025 at 8:20 AM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> >
> > Hi,
> >
> > While reading autovacuum.c, I found the following comments in
> > AutoVacLauncherMain() right before the call to rebuild_database_list();
> >
> > * Create the initial database list. The invariant we want this list to
> > * keep is that it's ordered by decreasing next_time. As soon as an entry
> >
> > However, I couldn't fnd any variable named "next_time". I believe it actually refers
> > to adl_next_worker and the comments should use "next_worker" as is done in other nereby
> > comments. I've attahed a patch to address this.
> >
>
> I agree with your analysis. WIll push the patch shortly, barring any objections.

Thank you!

Yugo Nagata
Regards,

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-08-04 01:46:45 Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions
Previous Message Noah Misch 2025-08-04 00:03:21 Re: Test instability when pg_dump orders by OID