From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fix a typo of comments in AutoVacLauncherMain |
Date: | 2025-08-01 17:00:48 |
Message-ID: | CAD21AoAB-g5ZWi4-tb8YahD1Qhc3zVjzt2M-6Bh1GR9ySBU84A@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Aug 1, 2025 at 8:20 AM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
>
> Hi,
>
> While reading autovacuum.c, I found the following comments in
> AutoVacLauncherMain() right before the call to rebuild_database_list();
>
> * Create the initial database list. The invariant we want this list to
> * keep is that it's ordered by decreasing next_time. As soon as an entry
>
> However, I couldn't fnd any variable named "next_time". I believe it actually refers
> to adl_next_worker and the comments should use "next_worker" as is done in other nereby
> comments. I've attahed a patch to address this.
>
I agree with your analysis. WIll push the patch shortly, barring any objections.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2025-08-01 17:17:04 | Re: Bug in brin_minmax_multi_distance_numeric() |
Previous Message | Andrew Dunstan | 2025-08-01 16:58:34 | Re: Add support for specifying tables in pg_createsubscriber. |