Re: Accounting for metapages in genericcostestimate()

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Accounting for metapages in genericcostestimate()
Date: 2025-04-30 10:47:51
Message-ID: 202504301047.ek6tfqtkoz32@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Apr-28, Tom Lane wrote:

> @@ -135,6 +141,7 @@ typedef struct
> double numIndexTuples; /* number of leaf tuples visited */
> double spc_random_page_cost; /* relevant random_page_cost value */
> double num_sa_scans; /* # indexscans from ScalarArrayOpExprs */
> + BlockNumber numNonLeafPages; /* # of index pages that are not leafs */
> } GenericCosts;

The idea you described seems quite reasonable, though I didn't review
the patch in detail.

I find the use of "leafs" as plural for "leaf" a bit strange ...
We already have uses of that word, but I wonder if they don't mostly
or exclusively come from non-native English speakers.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2025-04-30 11:22:19 Re: Some problems regarding the self-join elimination code
Previous Message Daniel Gustafsson 2025-04-30 10:43:24 Re: Enhancing Memory Context Statistics Reporting