Re: BitmapHeapScan streaming read user and prelim refactoring

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: BitmapHeapScan streaming read user and prelim refactoring
Date: 2024-03-18 15:19:47
Message-ID: 20240318151947.uu2il7iegi2gkmol@liskov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 18, 2024 at 02:10:28PM +0200, Heikki Linnakangas wrote:
> On 14/02/2024 21:42, Andres Freund wrote:
> > On 2024-02-13 18:11:25 -0500, Melanie Plageman wrote:
> > > patch 0004 is, I think, a bug fix. see [2].
> >
> > I'd not quite call it a bugfix, it's not like it leads to wrong
> > behaviour. Seems more like an optimization. But whatever :)
>
> It sure looks like bug to me, albeit a very minor one. Certainly not an
> optimization, it doesn't affect performance in any way, only what EXPLAIN
> reports. So committed and backported that to all supported branches.

I've attached v7 rebased over this commit.

- Melanie

Attachment Content-Type Size
v7-0001-BitmapHeapScan-begin-scan-after-bitmap-creation.patch text/x-diff 2.8 KB
v7-0002-BitmapHeapScan-set-can_skip_fetch-later.patch text/x-diff 2.2 KB
v7-0003-Push-BitmapHeapScan-skip-fetch-optimization-into-.patch text/x-diff 15.0 KB
v7-0004-BitmapPrefetch-use-prefetch-block-recheck-for-ski.patch text/x-diff 2.2 KB
v7-0005-Update-BitmapAdjustPrefetchIterator-parameter-typ.patch text/x-diff 2.3 KB
v7-0006-table_scan_bitmap_next_block-returns-lossy-or-exa.patch text/x-diff 4.4 KB
v7-0007-Reduce-scope-of-BitmapHeapScan-tbmiterator-local-.patch text/x-diff 2.9 KB
v7-0008-Remove-table_scan_bitmap_next_tuple-parameter-tbm.patch text/x-diff 4.1 KB
v7-0009-Make-table_scan_bitmap_next_block-async-friendly.patch text/x-diff 22.9 KB
v7-0010-Hard-code-TBMIterateResult-offsets-array-size.patch text/x-diff 5.3 KB
v7-0011-Separate-TBM-Shared-Iterator-and-TBMIterateResult.patch text/x-diff 19.7 KB
v7-0012-v7-Streaming-Read-API.patch text/x-diff 56.1 KB
v7-0013-BitmapHeapScan-uses-streaming-read-API.patch text/x-diff 28.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2024-03-18 15:22:15 Re: small_cleanups around login event triggers
Previous Message Matthias van de Meent 2024-03-18 14:54:45 Re: documentation structure