| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | amit(dot)kapila16(at)gmail(dot)com |
| Cc: | shveta(dot)malik(at)gmail(dot)com, euler(at)eulerto(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: About a recently-added message |
| Date: | 2024-02-22 00:46:36 |
| Message-ID: | 20240222.094636.1437407921769529841.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Thu, 22 Feb 2024 09:36:43 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> Yes, I'm happy with all of the changes. The proposed patch appears to
> cover all instances related to slotsync.c, and it looks fine to
> me. Thanks!
I'd like to raise another potential issue outside the patch. The patch
needed to change only one test item even though it changed nine
messages. This means eigh out of nine messages that the patch changed
are not covered by our test. I doubt all of them are worth additional
test items; however, I think we want to increase coverage.
Do you think some additional tests for the rest of the messages are
worth the trouble?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Coleman | 2024-02-22 00:54:57 | Re: RFC: Logging plan of the running query |
| Previous Message | Heikki Linnakangas | 2024-02-22 00:37:16 | Re: Refactoring backend fork+exec code |