Re: About a recently-added message

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: amit(dot)kapila16(at)gmail(dot)com
Cc: shveta(dot)malik(at)gmail(dot)com, euler(at)eulerto(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: About a recently-added message
Date: 2024-02-22 00:36:43
Message-ID: 20240222.093643.197043171195377476.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Wed, 21 Feb 2024 14:57:42 +0530, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote in
> On Tue, Feb 20, 2024 at 3:21 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > okay, attached v2 patch with changed error msgs and double quotes
> > around logical.
> >
>
> Horiguchi-San, does this address all your concerns related to
> translation with these new messages?

Yes, I'm happy with all of the changes. The proposed patch appears to
cover all instances related to slotsync.c, and it looks fine to
me. Thanks!

I found that logica.c is also using the policy that I complained
about, but it is a separate issue.

./logical.c122: errmsg("logical decoding requires wal_level >= logical")));

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-02-22 00:37:16 Re: Refactoring backend fork+exec code
Previous Message David E. Wheeler 2024-02-22 00:13:14 Re: Patch: Add parse_type Function