| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Nathan Bossart <nathan(at)postgresql(dot)org> |
| Subject: | Re: core dumps in auto_prewarm, tests succeed |
| Date: | 2024-01-22 21:38:15 |
| Message-ID: | 20240122213815.GA1953592@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 22, 2024 at 01:24:54PM -0800, Andres Freund wrote:
> On 2024-01-22 15:19:36 -0600, Nathan Bossart wrote:
>> I think this is because the autoprewarm state was moved to a DSM segment,
>> and DSM segments are detached before the on_shmem_exit callbacks are called
>> during process exit. Moving apw_detach_shmem to the before_shmem_exit list
>> seems to resolve the crashes.
>
> That seems plausible. Would still be nice to have at least this test ensure
> that the shutdown code works. Perhaps just a check of the control file after
> shutdown, ensuring that the state is "shutdowned" vs crashed?
I'll give that a try. I'll also expand the comment above the
before_shmem_exit() call.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-01-22 22:27:43 | Re: core dumps in auto_prewarm, tests succeed |
| Previous Message | Tom Lane | 2024-01-22 21:31:48 | Re: Improving EXPLAIN's display of SubPlan nodes |