| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Nathan Bossart <nathan(at)postgresql(dot)org> |
| Subject: | Re: core dumps in auto_prewarm, tests succeed |
| Date: | 2024-01-22 21:24:54 |
| Message-ID: | 20240122212454.tt4s5lcx4itahyeq@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2024-01-22 15:19:36 -0600, Nathan Bossart wrote:
> On Mon, Jan 22, 2024 at 02:44:57PM -0600, Nathan Bossart wrote:
> > On Mon, Jan 22, 2024 at 12:41:17PM -0800, Andres Freund wrote:
> >> I noticed that I was getting core dumps while executing the tests, without the
> >> tests failing. Backtraces are vriations of this:
> >
> > Looking, thanks for the heads-up.
>
> I think this is because the autoprewarm state was moved to a DSM segment,
> and DSM segments are detached before the on_shmem_exit callbacks are called
> during process exit. Moving apw_detach_shmem to the before_shmem_exit list
> seems to resolve the crashes.
That seems plausible. Would still be nice to have at least this test ensure
that the shutdown code works. Perhaps just a check of the control file after
shutdown, ensuring that the state is "shutdowned" vs crashed?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-01-22 21:29:10 | Re: Network failure may prevent promotion |
| Previous Message | Nathan Bossart | 2024-01-22 21:19:36 | Re: core dumps in auto_prewarm, tests succeed |