Re: A wrong comment about search_indexed_tlist_for_var

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: A wrong comment about search_indexed_tlist_for_var
Date: 2023-12-01 12:25:31
Message-ID: 202312011225.dzzagcyq5pnk@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2023-Dec-01, Richard Guo wrote:

> However, this cross-check will also be performed in non-debug builds
> ever since commit 867be9c07, which converts this check from Asserts to
> test-and-elog. The commit message there also says:
> Committed separately with the idea that eventually we'll revert
> this. It might be awhile though.
> I wonder if now is the time to revert it, since there have been no
> related bugs reported for quite a while.

I don't know anything about this, but maybe it would be better to let
these elogs there for longer, so that users have time to upgrade and
test. This new code has proven quite tricky, and if I understand
correctly, if we do run some query with wrong varnullingrels in
production code without elog and where Assert() does nothing, that might
silently lead to wrong results.

OTOH keeping the elog there might impact performance. Would that be

Álvaro Herrera 48°01'N 7°57'E —
"Debido a que la velocidad de la luz es mucho mayor que la del sonido,
algunas personas nos parecen brillantes un minuto antes
de escuchar las pelotudeces que dicen." (Roberto Fontanarrosa)

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-12-01 12:52:52 Re: pgsql: Clean up role created in new subscription test.
Previous Message Alvaro Herrera 2023-12-01 12:19:12 Re: pgsql: Clean up role created in new subscription test.