| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add 'worker_type' to pg_stat_subscription |
| Date: | 2023-09-20 23:34:51 |
| Message-ID: | 20230920233451.GA3055819@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 21, 2023 at 08:14:23AM +0900, Michael Paquier wrote:
> On Thu, Sep 21, 2023 at 09:01:01AM +1000, Peter Smith wrote:
>> One question -- the patch comment still says "Bumps catversion.", but
>> catversion.h change is missing from the v9 patch?
>
> Yeah, previous patches did that, but it is no big deal. My take is
> that it is a good practice to never do a catversion bump in posted
> patches, and that it is equally a good practice from Nathan to be
> reminded about that with the addition of a note in the commit message
> of the patch posted.
Right, I'll take care of it before committing. I'm trying to make sure I
don't forget. :)
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2023-09-21 00:06:03 | Re: Add 'worker_type' to pg_stat_subscription |
| Previous Message | Michael Paquier | 2023-09-20 23:14:23 | Re: Add 'worker_type' to pg_stat_subscription |