| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, nathandbossart(at)gmail(dot)com, davecramer(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, peter(at)eisentraut(dot)org, robertmhaas(at)gmail(dot)com, smithpb2250(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Using defines for protocol characters |
| Date: | 2023-08-15 21:40:07 |
| Message-ID: | 20230815214007.ptksp5nmtwt3yrjn@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-Aug-16, Michael Paquier wrote:
> On Wed, Aug 16, 2023 at 06:25:09AM +0900, Tatsuo Ishii wrote:
> > Currently pqcomm.h needs c.h which is not problem for Pgpool-II. But
> > what about other middleware?
>
> Why do you need to include directly c.h? There are definitions in
> there that are not intended to be exposed.
What this argument says is that these new defines should be in a
separate file, not in pqcomm.h. IMO that makes sense, precisely because
these defines should be usable by third parties.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2023-08-15 21:44:20 | Re: Using defines for protocol characters |
| Previous Message | Michael Paquier | 2023-08-15 21:37:18 | Re: Using defines for protocol characters |