Re: ERROR messages in VACUUM's PARALLEL option

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: dgrowleyml(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: ERROR messages in VACUUM's PARALLEL option
Date: 2023-04-12 01:21:22
Message-ID: 20230412.102122.1549156204085178034.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 11 Apr 2023 18:16:40 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > Thanks for chipping in on this. Can you confirm if you think this
> > should apply to VACUUM options? We're not talking GUCs here.
>
> My druthers would be to treat them similarly to GUCs.

IMHO I like this direction.

> I recognize that I might be in the minority, and that doing
> so would entail touching a lot of existing messages in this
> area. Nonetheless, I think this area is not being consistent
> with our wider conventions, which is why for example defGetString
> is out of step with these messages.

On the other hand, the documentation write optinos in uppercase
[1]. It is why I did not push hard for the normalization.

[1] https://www.postgresql.org/docs/devel/sql-vacuum.html

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2023-04-12 01:26:13 Re: longfin missing gssapi_ext.h
Previous Message Justin Pryzby 2023-04-12 01:19:59 Re: Add LZ4 compression in pg_dump