Re: Improve logging when using Huge Pages

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: michael(at)paquier(dot)xyz
Cc: pryzby(at)telsasoft(dot)com, sfrost(at)snowman(dot)net, alvherre(at)alvh(dot)no-ip(dot)org, andres(at)anarazel(dot)de, nathandbossart(at)gmail(dot)com, jchampion(at)timescale(dot)com, john(dot)naylor(at)enterprisedb(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com, noriyoshi(dot)shinoda(at)hpe(dot)com, pgsql-hackers(at)postgresql(dot)org, rjuju123(at)gmail(dot)com, sawada(dot)mshk(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, thomas(dot)munro(at)gmail(dot)com
Subject: Re: Improve logging when using Huge Pages
Date: 2023-04-11 07:41:18
Message-ID: 20230411.164118.2118064474465688828.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 11 Apr 2023 15:17:46 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> On Thu, Mar 23, 2023 at 05:25:46PM +0900, Kyotaro Horiguchi wrote:
> > Wouldn't storing the value in the shared memory itself work? Though,
> > that space does become almost dead for the server's lifetime...
>
> Sure, it would work. However, we'd still need an interface for the
> extra function. At this point, a GUC with an unknown state is kind of
> OK for me. Anyway, where would you stick this state?

(Digging memory..)

Sorry for confusion but I didn't mean to stick to the function. Just
I thought that some people seem to dislike having the third state for
the should-be-boolean variable.

So, I'm okay with GUC, having "unknown".

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2023-04-11 07:54:03 Re: [PoC] pg_upgrade: allow to upgrade publisher node
Previous Message Richard Guo 2023-04-11 07:19:41 A minor adjustment to get_cheapest_path_for_pathkeys