Re: Sketch of a fix for that truncation data corruption issue

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Sketch of a fix for that truncation data corruption issue
Date: 2023-04-03 10:34:28
Message-ID: 20230403103428.lgglnfn2qstrrbox@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-Dec-11, Tom Lane wrote:

> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Tue, Dec 11, 2018 at 3:06 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Anyway, if your assumption is that WAL replay must yield bit-for-bit
> >> the same state of the not-truncated pages that the master would have,
> >> then I doubt we can make this work. In that case we're back to the
> >> type of solution you rejected eight years ago, where we have to write
> >> out pages before truncating them away.
>
> > How much have you considered the possibility that my rejection of that
> > approach was a stupid and wrong-headed idea? I'm not sure I still
> > believe that not writing those buffers would have a meaningful
> > performance cost.
>
> Well, if *you're* willing to entertain that possiblity, I'm on board.
> That would certainly lead to a much simpler, and probably back-patchable,
> fix.

Hello,

Has this problem been fixed? I was under the impression that it had
been, but I spent some 20 minutes now looking for code, commits, or
patches in the archives, and I can't find anything relevant. Maybe it
was fixed in some different way that's not so obviously connected?

Thanks,

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Onur Tirtir 2023-04-03 11:09:50 RE: [EXTERNAL] Re: [PATCH] Report the query string that caused a memory error under Valgrind
Previous Message Quan Zongliang 2023-04-03 10:23:41 Why enable_hashjoin Completely disables HashJoin