| From: | "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com> |
|---|---|
| To: | Brar Piening <brar(at)gmx(dot)de> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: doc: add missing "id" attributes to extension packaging page |
| Date: | 2023-03-23 22:55:30 |
| Message-ID: | 20230323175530.2001f237@slate.karlpinc.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This is for the committer, as an FYI.
I cut out the <xsl:template name="section.heading"> portion
of the docbook XSLT and diffed it with the code for the
same template in the patch. The diff looks like:
-- /tmp/sections.xsl 2023-03-22 13:00:33.432968357 -0500
+++ /tmp/make_html_ids_discoverable_v3.patch 2023-03-22 13:03:39.776930603 -0500
@@ -52,5 +52,8 @@
</xsl:call-template>
</xsl:if>
<xsl:copy-of select="$title"/>
+ <xsl:call-template name="pg.id.link">
+ <xsl:with-param name="object" select="$section"/>
+ </xsl:call-template>
</xsl:element>
</xsl:template>
(So, this output would start with line 52 of the template,
not from the top of the stock sections.xsl file.)
However, I am not really familiar with exactly what flavor
of docbook, version, namespace-d or not, etc., that PG
uses. So I could be diffing with the wrong thing.
Hope this helps and is not just noise.
Regards,
Karl <kop(at)karlpinc(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-03-23 23:20:29 | Re: HOT chain validation in verify_heapam() |
| Previous Message | Tomas Vondra | 2023-03-23 22:46:14 | Re: pg_stats and range statistics |