Re: psql \watch 2nd argument: iteration count

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Andrey Borodin <amborodin86(at)gmail(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, sfrost(at)snowman(dot)net, peter(dot)eisentraut(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: psql \watch 2nd argument: iteration count
Date: 2023-03-09 19:25:26
Message-ID: 20230309192526.GA3703231@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

+ pg_log_error("Watch period must be non-negative number, but argument is '%s'", opt);

After looking around at the other error messages in this file, I think we
should make this more concise. Maybe something like

pg_log_error("\\watch: invalid delay interval: %s", opt);

+ free(opt);
+ resetPQExpBuffer(query_buf);
+ return PSQL_CMD_ERROR;

Is this missing psql_scan_reset(scan_state)?

I haven't had a chance to look closely at 0002 yet.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-03-09 19:43:01 Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)
Previous Message Jeff Davis 2023-03-09 19:23:35 Re: Add standard collation UNICODE