| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, Andrew Dunstan <andrew(at)dunslane(dot)net>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |
| Date: | 2023-02-22 22:47:13 |
| Message-ID: | 20230222224713.m65d55udzlq5mpbz@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-02-22 16:34:44 -0500, Tom Lane wrote:
> I wrote:
> > Andres Freund <andres(at)anarazel(dot)de> writes:
> >> Maybe it's worth sticking a StaticAssert() for the struct size
> >> somewhere.
>
> > Indeed. I thought we had one already.
>
> >> I'm a bit wary about that being too noisy, there are some machines with
> >> odd alignment requirements. Perhaps worth restricting the assertion to
> >> x86-64 + armv8 or such?
>
> > I'd put it in first and only reconsider if it shows unfixable problems.
>
> Now that we've got the sizeof(ExprEvalStep) under control, shouldn't
> we do the attached?
Indeed. Pushed.
Let's hope there's no rarely used architecture with odd alignment rules.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zheng Li | 2023-02-22 23:01:19 | Re: Support logical replication of DDLs |
| Previous Message | Peter Smith | 2023-02-22 22:45:02 | Re: [PATCH] Add pretty-printed XML output option |