Re: recovery modules

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: recovery modules
Date: 2023-02-17 22:53:42
Message-ID: 20230217225342.GC3217365@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Here is a new revision of the restore modules patch set. In this patch
set, the interface looks similar to the recent archive modules redesign,
and there are separate callbacks for retrieving different types of files.
I've attempted to address all the feedback I've received, but there was a
lot scattered across different threads, so it's possible I've missed
something. Note that 0001 is the stopgap fix for restore_command that's
being tracked elsewhere [0]. I was careful to avoid repeating the recent
mistake with the SIGTERM handling.

This patch set is still a little rough around the edges, but I wanted to
post it in case folks had general thoughts about the structure, interface,
etc. This implementation restores files synchronously one-by-one just like
archive modules, but in the future, I would like to add
asynchronous/parallel/batching support. My intent is for this work to move
us closer to that.


Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v12-0001-stopgap-fix-for-restore_command.patch text/x-diff 3.9 KB
v12-0002-introduce-routine-for-checking-mutually-exclusiv.patch text/x-diff 2.9 KB
v12-0003-refactor-code-for-restoring-via-shell.patch text/x-diff 27.2 KB
v12-0004-rename-archive-modules.sgml-to-archive-and-resto.patch text/x-diff 1.8 KB
v12-0005-restructure-archive-modules-docs-in-preparation-.patch text/x-diff 11.5 KB
v12-0006-introduce-restore_library.patch text/x-diff 70.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2023-02-17 23:04:51 Re: Reducing connection overhead in pg_upgrade compat check phase
Previous Message Nathan Bossart 2023-02-17 22:35:30 Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy