From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jelte Fennema <postgres(at)jeltef(dot)nl>, shiy(dot)fnst(at)fujitsu(dot)com, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: run pgindent on a regular basis / scripted manner |
Date: | 2023-02-16 04:34:04 |
Message-ID: | 20230216043404.GA2385625@rfd.leadboat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Feb 15, 2023 at 12:45:52PM -0600, Justin Pryzby wrote:
> On Mon, Feb 13, 2023 at 07:57:25AM -0500, Andrew Dunstan wrote:
> > On 2023-02-12 Su 15:59, Justin Pryzby wrote:
> > > It seems like if pgindent knows about git, it ought to process only
> > > tracked files. Then, it wouldn't need to manually exclude generated
> > > files, and it wouldn't process vpath builds and who-knows-what else it
> > > finds in CWD.
> >
> > I don't really want restrict this to tracked files because it would mean you
> > can't pgindent files before you `git add` them.
>
> I think you'd allow indenting files which were either tracked *or*
> specified on the command line.
>
> Also, it makes a more sense to "add" the file before indenting it, to
> allow checking the output and remove unrelated changes. So that doesn't
> seem to me like a restriction of any significance.
>
> But I would never want to indent an untracked file unless I specified
> it.
Agreed. I use pgindent three ways:
1. Indent everything that changed between master and the current branch. Most
common, since I develop nontrivial patches on branches.
2. Indent all staged files. For trivial changes.
3. Indent all tracked files. For typedefs.list changes.
That said, pre-2023 pgindent changed untracked files if called without a file
list. I've lived with that and could continue to do so.
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2023-02-16 04:36:16 | Re: some namespace.c refactoring |
Previous Message | Robert Haas | 2023-02-16 04:29:23 | Re: REASSIGN OWNED vs ALTER TABLE OWNER TO permission inconsistencies |