| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix GUC_NO_SHOW_ALL test scenario in 003_check_guc.pl |
| Date: | 2023-02-09 02:32:12 |
| Message-ID: | 20230209023212.GQ1653@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 09, 2023 at 10:28:14AM +0900, Michael Paquier wrote:
> On Wed, Feb 08, 2023 at 04:21:57PM +0530, Nitin Jadhav wrote:
> > Makes sense and the patch looks good to me.
>
> Ah, OK. Thanks for the feedback!
>
> I am wondering.. Did people notice that this adds GUC_NOT_IN_SAMPLE
> to config_file in guc_tables.c? This makes sense in the long run
> based on what this parameter is by design, still there may be an
> objection to doing that?
I think it's fine to add the flag.
See also:
https://www.postgresql.org/message-id/flat/20211129030833(dot)GJ17618(at)telsasoft(dot)com
|Since GUC_DISALLOW_IN_FILE effectively implies GUC_NOT_IN_SAMPLE in
|src/backend/utils/misc/help_config.c:displayStruct(), many of the
|redundant GUC_NOT_IN_SAMPLE could be removed.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2023-02-09 02:37:41 | Re: tests against running server occasionally fail, postgres_fdw & tenk1 |
| Previous Message | Kyotaro Horiguchi | 2023-02-09 02:31:49 | Re: [Proposal] Add foreign-server health checks infrastructure |