From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Jelte Fennema <postgres(at)jeltef(dot)nl>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Jesse Zhang <sbjesse(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: run pgindent on a regular basis / scripted manner |
Date: | 2023-01-20 17:58:06 |
Message-ID: | 20230120175806.iogdcra2xpmmh5de@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2023-01-20 12:09:05 -0500, Tom Lane wrote:
> Jelte Fennema <postgres(at)jeltef(dot)nl> writes:
> > To me a master branch that pgindent never complains about sounds
> > amazing! And I personally think rejection of unindented pushes and
> > cfbot complaining about unindented patches would be a very good thing,
> > because that seems to be the only solution that could achieve that.
>
> The core problem here is that requiring that would translate to
> requiring every code contributor to have a working copy of pg_bsd_indent.
Wouldn't just every committer suffice?
> Maybe that's not a huge lift, but it'd be YA obstacle to new contributors,
> and we don't need any more of those.
>
> Yeah, if we switched to some other tool maybe we could reduce the size
> of that problem. But as Bruce replied, we've not found another one that
> (a) can be coaxed to make output comparable to what we're accustomed to
> and (b) seems decently well maintained.
One question around this is how much change we'd accept. clang-format for
example is well maintained and can get somewhat close to our style - but
there are things that can't easily be approximated.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2023-01-20 18:10:38 | Re: almost-super-user problems that we haven't fixed yet |
Previous Message | Tom Lane | 2023-01-20 17:57:48 | Re: real/float example for testlibpq3 |