| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactor recordExtObjInitPriv() |
| Date: | 2023-01-12 00:04:37 |
| Message-ID: | 20230112000437.GA2032194@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 27, 2022 at 09:56:10AM +0100, Peter Eisentraut wrote:
> Refactor recordExtObjInitPriv(): Instead of half a dozen of
> mostly-duplicate conditional branches, write one common one that can handle
> most catalogs. We already have all the information we need, such as which
> system catalog corresponds to which catalog table and which column is the
> ACL column.
This seems reasonable.
> + /* This will error on unsupported classoid. */
> + else if (get_object_attnum_acl(classoid))
nitpick: I would suggest explicitly checking that it isn't
InvalidAttrNumber instead of relying on it always being 0.
> - classoid == AggregateRelationId ||
I noticed that AggregateRelationId isn't listed in the ObjectProperty
array, so I think recordExtObjInitPriv() will begin erroring for that
classoid instead of ignoring it like we do today.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2023-01-12 00:06:31 | Re: Reducing the WAL overhead of freezing in VACUUM by deduplicating per-tuple freeze plans |
| Previous Message | Jeff Davis | 2023-01-11 23:52:26 | Re: Rework of collation code, extensibility |