Re: meson PGXS compatibility

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: meson PGXS compatibility
Date: 2022-10-13 05:23:40
Message-ID: 20221013052340.mr3olt5st5xfvy6w@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-10-12 07:50:07 +0200, Peter Eisentraut wrote:
> On 05.10.22 22:07, Andres Freund wrote:
> > 0001: autoconf: Unify CFLAGS_SSE42 and CFLAGS_ARMV8_CRC32C
>
> I wonder, there has been some work lately to use SIMD and such in other
> places. Would that affect what kinds of extra CPU-specific compiler flags
> and combinations we might need?

The current infrastructure is very CRC specific, so I don't think this change
would stand in the way of using sse specific flags in other places.

> > 0005: meson: Add PGXS compatibility
> >
> > The actual meson PGXS compatibility. Plenty more replacements to do, but
> > suffices to build common extensions on a few platforms.
> >
> > What level of completeness do we want to require here?
>
> I have tried this with a few extensions. Seems to work alright. I don't
> think we need to overthink this. The way it's set up, if someone needs
> additional variables set, they can easily be added.

Yea, I am happy enough with it now that the bulk is out of src/meson.build and
strip isn't set to an outright wrong value.

Thanks!

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2022-10-13 05:41:32 Re: Schema variables - new implementation for Postgres 15
Previous Message Andres Freund 2022-10-13 05:16:48 Re: meson PGXS compatibility