| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Soumyadeep Chakraborty <soumyadeep2007(at)gmail(dot)com>, "Sanaba, Bilva" <bilvas(at)amazon(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adding Support for Copy callback functionality on COPY TO api |
| Date: | 2022-10-08 17:37:41 |
| Message-ID: | 20221008173741.GB882834@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 08, 2022 at 02:11:38PM +0900, Michael Paquier wrote:
> Using an ereport(NOTICE) to show the data reported in the callback is
> fine by me. How about making the module a bit more modular, by
> passing as argument a regclass and building a list of arguments with
> it? You may want to hold the ShareAccessLock on the relation until
> the end of the transaction in this example.
Yeah, that makes more sense. It actually simplifies things a bit, too.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Support-COPY-TO-callback-functions.patch | text/x-diff | 12.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-10-08 17:40:00 | Re: START_REPLICATION SLOT causing a crash in an assert build |
| Previous Message | Andres Freund | 2022-10-08 17:32:36 | Re: Non-robustness in pmsignal.c |