Re: predefined role(s) for VACUUM and ANALYZE

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Date: 2022-09-30 23:18:34
Message-ID: 20220930231834.GA366260@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Sep 30, 2022 at 07:05:38PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> On Fri, Sep 30, 2022 at 06:00:53PM -0400, Tom Lane wrote:
>>> ... and now requires double alignment ... did you fix its typalign?
>> Nope, I missed that, thanks for pointing it out. Should we move ai_privs
>> to the beginning of the struct, too?
> Don't see any point, there won't be any padding. If we ever change the
> sizeof(Oid), or add more fields, we can consider what to do then.

Sounds good. Here's a new patch set with aclitem's typalign fixed.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v7-0001-Change-AclMode-from-a-uint32-to-a-uint64.patch text/x-diff 7.4 KB
v7-0002-Simplify-WARNING-messages-emitted-when-skipping-v.patch text/x-diff 15.8 KB
v7-0003-Allow-granting-VACUUM-and-ANALYZE-privileges-on-r.patch text/x-diff 38.8 KB
v7-0004-Add-pg_vacuum_all_tables-and-pg_analyze_all_table.patch text/x-diff 9.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-09-30 23:52:44 Re: pgsql: Avoid improbable PANIC during heap_update.
Previous Message Lukas Fittl 2022-09-30 23:17:25 Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)