From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: predefined role(s) for VACUUM and ANALYZE |
Date: | 2022-10-14 23:37:38 |
Message-ID: | CADkLM=fg15_SYRGBcTFpoW-vVUTCkLfe+NTM0G32RjWY1W5Pvw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>
> Sounds good. Here's a new patch set with aclitem's typalign fixed.
>
Patch applies.
Passes make check and make check-world.
Test coverage seems adequate.
Coding is very clear and very much in the style of the existing code. Any
quibbles I have with the coding style are ones I have with the overall
pg-style, and this isn't the forum for that.
I haven't done any benchmarking yet, but it seems that the main question
will be the impact on ordinary DML statements.
I have no opinion about the design debate earlier in this thread, but I do
think that this patch is ready and adds something concrete to the ongoing
discussion.
From | Date | Subject | |
---|---|---|---|
Next Message | Tatsuo Ishii | 2022-10-15 01:40:29 | Re: make_ctags: use -I option to ignore pg_node_attr macro |
Previous Message | Jeff Davis | 2022-10-14 23:00:10 | Re: Refactor to introduce pg_strcoll(). |