| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Arne Roland <A(dot)Roland(at)index(dot)de>, Amit Langote <amitlangote09(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Subject: | Re: missing indexes in indexlist with partitioned tables |
| Date: | 2022-09-17 18:37:01 |
| Message-ID: | 20220917183701.dxooicewyk6yy5vd@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Sep-16, David Rowley wrote:
> I kinda disagree with Alvaro's fix in 05fb5d661. I think indexlist is
> the place to store these details. That commit added the following
> comment:
>
> /*
> * Ignore partitioned indexes, since they are not usable for
> * queries.
> */
>
> But neither are hypothetical indexes either, yet they're added to
> RelOptInfo.indexlist.
>
> I think the patch should be changed so that the existing list is used
> and we find another fix for the problems Alvaro fixed in 05fb5d661.
> Unfortunately, there was no discussion marked on that commit message,
> so it's not quite clear what the problem was. I'm unsure if there was
> anything other than CLUSTER that was broken.
After a bit of trawling through the archives, I found it here:
https://www.postgresql.org/message-id/20180124162006.pmapfiznhgngwtjf%40alvherre.pgsql
I think there was insufficient discussion and you're probably right that
it wasn't the best fix. I don't object to finding another fix.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2022-09-17 18:43:31 | Re: [EXTERNAL] Re: Support load balancing in libpq |
| Previous Message | Peter Geoghegan | 2022-09-17 18:36:48 | Re: Making C function declaration parameter names consistent with corresponding definition names |