| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, samay sharma <smilingsamay(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Subject: | Re: [RFC] building postgres with meson - v12 |
| Date: | 2022-08-28 17:08:07 |
| Message-ID: | 20220828170806.GN2342@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
with_temp_install is repeated twice in prove_check:
> Subject: [PATCH v12 02/15] Split TESTDIR into TESTLOGDIR and TESTDATADIR
>
> - TESTDIR='$(CURDIR)/tmp_check' $(with_temp_install)
> PGPORT='6$(DEF_PGPORT)' \
> + TESTLOGDIR='$(CURDIR)/tmp_check/log' $(with_temp_install) \
> + TESTDATADIR='$(CURDIR)/tmp_check' $(with_temp_install) \
> + PGPORT='6$(DEF_PGPORT)' \
Before running an individual test like "meson test recovery/017_shm",
it's currently necessary to first manually run "meson test tmp_install".
Is it possible to make that happen automatically ?
You're running tap tests via a python script. There's no problem with
that, but it's different from what's done by the existing makefiles.
I was able to remove the python indirection - maybe that's better to
talk about on the CI thread? That moves some setup for TAP tests
(TESTDIR, PATH, cd) from Makefile into the existing perl, which means
less duplication.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-08-28 17:10:29 | Re: CI and test improvements |
| Previous Message | Andres Freund | 2022-08-28 16:07:52 | Re: CI and test improvements |