Re: [RFC] building postgres with meson - v12

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, samay sharma <smilingsamay(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: [RFC] building postgres with meson - v12
Date: 2022-08-27 18:04:47
Message-ID: 20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Attached is v12 of the meson patchset. Lots of improvements:

- initial set of docs for building with meson, contributed by Samay

- PGXS, .pc generation for extensions, making macos tests work when SIP is
enabled, precompiled headers support are all now separate commits

as suggested by Peter Eisentraut

- aix, solaris builds work now (both on gcc only)

- most of the operating system specific considerations are now collected in
one place

There's still the odd check around, but it's mostly for stuff where it seems
to make sense to leave decentralized (e.g. do we need to invoke the dtrace
binary on darwin, using wldap32 on windows, ...)

- split out the existing PG_SYSROOT selection logic from darwin's template
into src/tools/darwin_sysroot

Peter E. rightfully complained that the logic I had so far wasn't
equivalent, and it's finnicky enough that it doesn't seem like a good idea
to have two copies. Not sure about the location, perhaps it should be in
config/ instead?

- loads of cleanups, rebasing, etc

The known things that I think need to be fixed before we could consider test
driving this on a larger scale are:

- the various global variables assembled in the toplevel meson.build need
comments explaining them (e.g. cflags, cflags_sl, ...)

- choice of semaphore API needs to be cleaned up, that should be easy now, but
I thought that I needed to get a new version out first

- there's a few configure tests denoted with FIXMEs, most importantly I
haven't caught up to the PGAC_LDAP_SAFE

Greetings,

Andres Freund

Attachment Content-Type Size
v12-0001-Don-t-hardcode-tmp_check-as-test-directory-for-t.patch text/x-diff 6.9 KB
v12-0002-Split-TESTDIR-into-TESTLOGDIR-and-TESTDATADIR.patch text/x-diff 5.0 KB
v12-0003-meson-prereq-Extend-gendef.pl-in-preparation-for.patch text/x-diff 4.9 KB
v12-0004-meson-prereq-Add-src-tools-gen_export.pl.patch text/x-diff 2.4 KB
v12-0005-meson-prereq-Refactor-PG_TEST_EXTRA-logic-in-aut.patch text/x-diff 4.0 KB
v12-0006-meson-prereq-Fix-warning-compat_informix-rnull.p.patch text/x-diff 1.5 KB
v12-0007-meson-prereq-Move-darwin-sysroot-determination-i.patch text/x-diff 4.4 KB
v12-0008-meson-Add-meson-based-buildsystem.patch text/x-diff 350.5 KB
v12-0009-meson-ci-Build-both-with-meson-and-as-before.patch text/x-diff 31.0 KB
v12-0010-meson-Add-support-for-relative-rpaths-fixing-tes.patch text/x-diff 7.3 KB
v12-0011-meson-Add-docs-for-building-with-meson.patch text/x-diff 67.9 KB
v12-0012-meson-Add-PGXS-compatibility.patch text/x-diff 7.4 KB
v12-0013-meson-Add-postgresql-extension.pc-for-building-e.patch text/x-diff 3.7 KB
v12-0014-meson-Add-LLVM-bitcode-emission.patch text/x-diff 5.2 KB
v12-0015-meson-Add-support-for-building-with-precompiled-.patch text/x-diff 14.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-08-27 19:27:57 Re: [PATCH] Add native windows on arm64 support
Previous Message Jonathan S. Katz 2022-08-27 16:30:43 Re: SQL/JSON features for v15