Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: David Zhang <david(dot)zhang(at)highgo(dot)ca>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)
Date: 2022-08-24 14:30:04
Message-ID: 20220824143004.fu6dtvmc7niyi2xf@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Aug-19, David Zhang wrote:

> Should these obviously possible replacement of the standard library function
> "memset" be considered as well? For example, something like the attached one
> which is focusing on the pageinspect extension only.

If you do this, you're creating a potential backpatching hazard. This
is OK if we get something in return, so a question to ask is whether
there is any benefit in doing it.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Most hackers will be perfectly comfortable conceptualizing users as entropy
sources, so let's move on." (Nathaniel Smith)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-08-24 14:40:01 Re: Inconsistencies around defining FRONTEND
Previous Message Andrew Dunstan 2022-08-24 14:24:50 Re: Strip -mmacosx-version-min options from plperl build