From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, samay sharma <smilingsamay(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
Subject: | Re: Inconsistencies around defining FRONTEND |
Date: | 2022-08-24 01:55:44 |
Message-ID: | 20220824015544.pxjxnv6dbjg4ytom@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2022-08-23 19:50:00 -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Tue, Aug 23, 2022 at 7:24 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> Just to make sure I understand - you're just trying to get rid of the #define
> >> frontends, not the -DFRONTENDs passed in from the Makefile? Because afaics we
> >> still need those, correct?
>
> > Oh, yeah, this only fixes the #define ones. But maybe fixing the other
> > ones with a similar approach would be possible?
>
> > I really don't see why we should tolerate having #define FRONTEND in
> > more than once place.
>
> src/port and src/common really need to do it like that (ie pass in
> the -D switch) so that the identical source file can be built
> both ways. Maybe we could get rid of -DFRONTEND in other places,
> like pg_rewind and pg_waldump.
We could, if we make xlogreader.c and the rmgrdesc routines built as part of
src/common. I don't really see how otherwise.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2022-08-24 02:04:57 | Re: Symbol referencing errors |
Previous Message | Kyotaro Horiguchi | 2022-08-24 01:48:01 | Re: add checkpoint stats of snapshot and mapping files of pg_logical dir |