| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: designated initializers |
| Date: | 2022-08-10 16:56:29 |
| Message-ID: | 20220810165629.nz22lifj4as3g7ut@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-08-10 16:03:00 +0200, Alvaro Herrera wrote:
> (Coming from https://postgr.es/m/20220809193616.5uucf33piwdxn452@alvherre.pgsql )
>
> On 2022-Aug-09, Alvaro Herrera wrote:
>
> > On 2022-Aug-09, Andres Freund wrote:
> >
> > > Mildly wondering whether we ought to use designated initializers instead,
> > > given we're whacking it around already. Too easy to get the order wrong when
> > > adding new members, and we might want to have optional callbacks too.
> >
> > Strong +1. It makes code much easier to navigate (see XmlTableRoutine
> > and compare with heapam_methods, for example).
>
> For example, I propose the attached.
+1 I've fought with this one when fixing a conflict when rebasing a patch...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-08-10 16:57:34 | Re: moving basebackup code to its own directory |
| Previous Message | Jonathan S. Katz | 2022-08-10 16:41:25 | Re: moving basebackup code to its own directory |