| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |
| Date: | 2022-07-21 11:17:51 |
| Message-ID: | 20220721111751.x7hod2xgrd76xr5c@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Jul-21, Thomas Munro wrote:
> On Wed, Jul 20, 2022 at 10:51 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> > v26 here. I spent some time fighting the readdir() stuff for
> > Windows (so that get_dirent_type returns LNK for junction points)
> > but couldn't make it to work and was unable to figure out why.
>
> Was it because of this?
>
> https://www.postgresql.org/message-id/CA%2BhUKGKv%2B736Pc8kSj3%3DDijDGd1eC79-uT3Vi16n7jYkcc_raw%40mail.gmail.com
Oh, that sounds very likely, yeah. I didn't think of testing the
FILE_ATTRIBUTE_DIRECTORY bit for junction points.
I +1 pushing both of these patches to 14. Then this patch becomes a
couple of lines shorter.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Before you were born your parents weren't as boring as they are now. They
got that way paying your bills, cleaning up your room and listening to you
tell them how idealistic you are." -- Charles J. Sykes' advice to teenagers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-07-21 11:20:26 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |
| Previous Message | Martin Kalcher | 2022-07-21 11:15:43 | Re: [PATCH] Introduce array_shuffle() and array_sample() |