| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Petr Vejsada <pve(at)paymorrow(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade (12->14) fails on aggregate |
| Date: | 2022-06-22 23:58:45 |
| Message-ID: | 20220622235845.GV22452@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Fri, Jun 17, 2022 at 10:14:13AM -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Thu, Jun 16, 2022 at 10:01 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> >> To me, oid>=16384 seems more hard-wired than namespace!='pg_catalog'.
>
> > Extensions can be installed into pg_catalog, but they can't get
> > low-numbered OIDs.
>
> Exactly. (To be clear, I had in mind writing something involving
> FirstNormalObjectId, not that you should put literal "16384" in the
> code.)
Actually, 16384 is already used in two other places in check.c, so ...
done like that for consistency.
Also fixes parenthesis, typos, and renames vars.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-WIP-pg_upgrade-check-detect-old-polymorphics-from.patch | text/x-diff | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-06-23 02:03:33 | Re: Postgres do not allow to create many tables with more than 63-symbols prefix |
| Previous Message | PG Bug reporting form | 2022-06-22 23:05:45 | BUG #17530: pg_dump comment on triggers is "off" by comparison to all of the other objects... |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-06-23 00:01:13 | Re: Missing reference to pgstat_replslot.c in pgstat.c |
| Previous Message | Andres Freund | 2022-06-22 23:49:08 | Re: Make COPY extendable in order to support Parquet and other formats |