Re: pgsql: Add option to use ICU as global locale provider

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add option to use ICU as global locale provider
Date: 2022-03-18 07:40:51
Message-ID: 20220318074051.n46mkwp2zkbxeesf@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Mar 18, 2022 at 02:36:48PM +0800, Julien Rouhaud wrote:
> On Fri, Mar 18, 2022 at 06:15:47PM +1300, Thomas Munro wrote:
> >
> > No idea what's happening here but one observation is that that animal
> > is running an older distro that shipped with ICU 5.0. Commit b8f9a2a6
> > may hold a clue...
>
> Right. I'm setting up a similar podman environment, hopefully more info soon.

And indeed b8f9a2a6 is the problem. We would need some form of
icu_set_collation_attributes() on the frontend side if we want to detect such a
problem on older ICU version at the expected moment rather than when
bootstrapping the info. A similar check is also needed in createdb().

I was thinking that this could be the cause of problem reported by Andres on
centos 7 (which seems to ship ICU 50), but postinit.c calls
make_icu_collator(), which sets the attribute as expected. Maybe it's because
old ICU version simply don't understand locale ID like "en-u-kf-upper" and
silently falls back to the root collator?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Julien Rouhaud 2022-03-18 09:27:49 Re: pgsql: Add option to use ICU as global locale provider
Previous Message Julien Rouhaud 2022-03-18 06:36:48 Re: pgsql: Add option to use ICU as global locale provider

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-03-18 08:02:52 Re: add checkpoint stats of snapshot and mapping files of pg_logical dir
Previous Message Kyotaro Horiguchi 2022-03-18 07:38:57 Re: [PATCH] Accept IP addresses in server certificate SANs