Re: [PATCH] Accept IP addresses in server certificate SANs

At Thu, 17 Mar 2022 21:55:07 +0000, Jacob Champion <pchampion(at)vmware(dot)com> wrote in
> On Wed, 2022-03-16 at 23:49 +0000, Jacob Champion wrote:
> > Thank you for the explanation -- the misunderstanding was all on my
> > end. I thought you were asking me to move the check_cn assignment
> > instead of copying it to the end. I agree that your suggestion is much
> > clearer, and I'll make that change tomorrow.
>
> Done in v8. Thanks again for your suggestions (and for your
> perseverance when I didn't get it)!

Thanks! .. and some nitpicks..(Sorry)

fe-secure-common.c doesn't need netinet/in.h.

+++ b/src/include/utils/inet.h
..
+#include "common/inet-common.h"

I'm not sure about the project policy on #include practice, but I
think it is the common practice not to include headers that are not
required by the file itself. In this case, fe-secure-common.h itself
doesn't need the include. Instead, fe-secure-openssl.c and
fe-secure-common.c needs the include.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center