Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

From: Andres Freund <andres(at)anarazel(dot)de>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b
Date: 2022-03-04 21:56:57
Message-ID: 20220304215657.zk7czqnfk674g7ho@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-03-05 09:29:01 +1300, Thomas Munro wrote:
> On Sat, Mar 5, 2022 at 7:10 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > Or perhaps pg_ctl ought to pass CREATE_NEW_PROCESS_GROUP to CreateProcess()?
> > The lack of a process group would explain why we're getting signalled on
> > ctrl-c...
>
> I thought that sounded promising, given that the recent Cirrus agent
> commit you pointed to says "Always kill spawned shell's process group
> to avoid pipe FD hangs", and given that we do something conceptually
> similar on Unix. It doesn't seem to help, though...
>
> https://cirrus-ci.com/task/5572163880091648

I suspect one also needs the console detach thing.

I don't really understand why start_postmaster() bothers to wrap postmaster
start through cmd.exe, particularly when it prevents us from getting
postmaster's pid. Also the caveats around cmd.exe and sharing mode.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2022-03-04 22:03:09 Re: Avoiding smgrimmedsync() during nbtree index builds
Previous Message Tom Lane 2022-03-04 21:51:32 Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b