Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Dong Wook Lee <sh95119(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal
Date: 2022-02-27 11:55:26
Message-ID: 20220227115526.vhpfhlinbruax5ky@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Sun, Feb 27, 2022 at 08:45:13PM +0900, Dong Wook Lee wrote:
>
> I found some redundant function calls in
> pg_stat_statements.c/pg_stat_statements_internal(),
> There is no need to call GetUserId() again because the value was
> previously obtained.

Indeed. I doubt it will make any real difference but it doesn't hurt to fix
it.

Patch looks good to me.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-02-27 12:06:59 Re: PATCH: add "--config-file=" option to pg_rewind
Previous Message Dong Wook Lee 2022-02-27 11:45:13 pg_stat_statements: remove redundant function call in pg_stat_statements_internal