Re: Fix a typo in pg_receivewal.c's get_destination_dir()

From: Andres Freund <andres(at)anarazel(dot)de>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix a typo in pg_receivewal.c's get_destination_dir()
Date: 2022-02-27 00:46:37
Message-ID: 20220227004637.6wzkphcrjnl3byvz@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-02-26 22:04:13 +0530, Bharath Rupireddy wrote:
> It looks like there's a typo in pg_receivewal.c's
> get_destination_dir(), that is, use the function parameter dest_folder
> instead of global variable basedir in the error message. Although
> there's no harm in it as basedir is a global variable in
> pg_receivewal.c, let's use the function parameter to be in sync with
> close_destination_dir.
>
> Attaching a tiny patch to fix it.

Good catch, pushed.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-02-27 01:09:08 Re: Adding CI to our tree
Previous Message Justin Pryzby 2022-02-27 00:37:21 Re: Commitfest manager for 2022-03