making pg_regress less noisy by removing boilerplate

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: making pg_regress less noisy by removing boilerplate
Date: 2022-02-21 16:47:36
Message-ID: 20220221164736.rq3ornzjdkmwk2wo@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

When running check-world, a good chunk of the output is just pg_regress
boilerplate. It doesn't matter when running tests individually or for tests
with a lot of individual tests like the main regression tests. But for lots of
the rest it is noisy. These days there are many more regression tests than
there used to be when the output was designed...

============== creating temporary instance ==============
============== initializing database system ==============
============== starting postmaster ==============
running on port 51696 with PID 1156405
============== creating database "contrib_regression" ==============
CREATE DATABASE
ALTER DATABASE
============== installing hstore ==============
CREATE EXTENSION
============== running regression test queries ==============
test python3/hstore_plpython ... ok 50 ms
============== shutting down postmaster ==============
============== removing temporary instance ==============

=====================
All 1 tests passed.
=====================

============== creating temporary instance ==============
[...]

It seems we could

- combine "creating temporary instance", "initializing database system" and
"starting postmaster"
- combine "creating database" and "installing *" sections
- combine "shutting down postmaster" and "removing temporary instance"
- put CREATE DATABASE, ALTER DATABASE, CREATE EXTENSION into a single line

without loosing much information, but reducing the vertical space used a lot?

It might even be worth further collapsing "starting postmaster" and "creating
database" etc into one.

There's also Daniel's patch of adding a tap compatible output mode [1]. I
still like that idea a lot - being able to parse test successes / failures in
a uniform way across tests would be great. The meson testrunner for example
would benefit from that. But if I understood that patch, it'd also benefit
from the reduction in unnecessary headers, albeit not as crucially.

Greetings,

Andres Freund

[1] https://postgr.es/m/62A6B9F0-C3D3-45CD-8E8B-90A8E5B08DFA%40yesql.se

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chapman Flack 2022-02-21 16:49:11 Re: Reducing power consumption on idle servers
Previous Message Andres Freund 2022-02-21 16:35:57 Re: pg_upgrade verbosity when redirecting output to log file