Re: 2022-01 Commitfest

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: 2022-01 Commitfest
Date: 2022-02-02 17:28:53
Message-ID: 20220202172853.64yxtit33vppswdl@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On Wed, Feb 02, 2022 at 12:09:06PM -0500, Greg Stark wrote:
> I gave two reviews and received one review but the patches have been
> "Moved to next CF".

For now I only moved to the next commit fest the patches that were in "Needs
Review" or "Ready for Committer". I'm assuming that you failed to update the
cf entry accordingly after your reviews, so yeah the patches were moved.

I unfortunately don't have a lot of time right now and the commit fest still
needs to be closed, so I prefer to use my time triaging the patches that were
marked as Waiting on Author rather than going through a couple hundred of
threads yet another time.

> Should I update them to "Returned with Feedback"
> given they all did get feedback? I was under the impression "Moved to
> next CF" was only for patches that didn't get feedback in a CF and
> were still waiting for feedback.

My understanding of "Returned with Feedback" is that the patch implements
something wanted, but as proposed won't be accepted without a major redesign or
something like that. Not patches that are going through normal "review /
addressing reviews" cycles. And definitely not bug fixes either.

If we close all patches that had a review just because they weren't perfect in
their initial submission, we're just going to force everyone to re-register
their patch for every single commit fest. I don't see that doing anything
apart from making sure that everyone stops contributing.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jaime Casanova 2022-02-02 17:45:40 Re: 2022-01 Commitfest
Previous Message Christoph Heiss 2022-02-02 17:23:18 Re: [PATCH] Add reloption for views to enable RLS