| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix headerscheck failure in replication/worker_internal.h |
| Date: | 2021-11-16 18:16:45 |
| Message-ID: | 202111161816.bncq4ckt6ahl@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2021-Nov-16, Stephen Frost wrote:
> Not against possibly changing that but I don’t get the point of including
> be-gssapi-common.h if it’s not enabled in the build and typically if GSSAPI
> is possible and the reason for including be-gssapi-common.h then there’s
> other things that need to be under a ifdef, again, as in auth.c
BTW, this is exactly why my first suggestion was to add an exclusion
rule to headerscheck so that be-gssapi-common.h is not verified by that
script. After re-reading your response, that looks like a reasonable
answer too.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2021-11-16 18:57:15 | Re: pgsql: Fix headerscheck failure in replication/worker_internal.h |
| Previous Message | Alvaro Herrera | 2021-11-16 18:01:54 | Re: pgsql: Fix headerscheck failure in replication/worker_internal.h |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua Brindle | 2021-11-16 18:26:37 | Re: Support for NSS as a libpq TLS backend |
| Previous Message | Mark Dilger | 2021-11-16 18:12:26 | Re: Non-superuser subscription owners |